Handle empty query params properly #91

Merged

jalil merged 2 commits from push-258298cb008a5819f12721a1101c162b into main 2025-01-31 21:35:59 +01:00

Conversation 1 Commits 2 Files changed 2 +66 -4

jalil commented 2025-01-31 21:33:23 +01:00

Owner

Copy link

FRITZ!Box generates empty query params (e.g. /update?ipv4=&ipv6=::1) when only one IP is updated. This handles that properly.

#90 was merged prematurely.

FRITZ!Box generates empty query params (e.g. /update?ipv4=&ipv6=::1) when only one IP is updated. This handles that properly. #90 was merged prematurely.

jalil added 2 commits 2025-01-31 21:33:23 +01:00

fix(webnsupdate): make IP none when query is empty ... 2f97008475

This happens when one of the IPs hasn't changed (but the other has) in
the FRITZ!Box DDNS client.

fix(tests): add case for when query has empty string ... 70ed898f1d

This is produced by the FRITZ!Box DDNS client.

jalil self-assigned this 2025-01-31 21:33:25 +01:00

forgejo-actions commented 2025-01-31 21:35:37 +01:00

First-time contributor

Copy link

Flake output sizes

Definitions:

• Name: the name of the package/configuration.
• Size: the closure size (size on disk/NAR size + all transitive dependencies).
• NAR Size: the size of the build output (package without the dependencies).
• [NAR] Size Change: the amount changed compared to the main branch.

Tips on reading this data:

• For NixOS configurations you generally care only about the Size (closure size/size on disk).
  • Reduce the Size by disabling unneeded services/default packages.
• For Packages you care about both the Size and the NAR Size.
  • Reduce the NAR Size by reducing the size of the build outputs, e.g. don't copy unnecessary data to the $out dir, optimize binaries for size, etc.
  • Reduce the Size by reducing the dependencies (e.g. buildInputs).
  • Don't worry too much about size, some dependencies are deduplicated, e.g. glibc adds ~40MiB to the Size, but is generally shared by ~every binary on the system, so, chances are, you are already including it from somewhere else and statically linking with e.g. musl is not gonna improve things.

Packages

Name	Size	Size Change	NAR Size	NAR Size Change
default	35MiB	192B	2.8MiB	192B
git-cliff	60MiB	0B	19MiB	0B
webnsupdate	35MiB	192B	2.8MiB	192B

# Flake output sizes **Definitions:** - `Name`: the name of the package/configuration. - `Size`: the closure size (size on disk/NAR size + all transitive dependencies). - `NAR Size`: the size of the build output (package without the dependencies). - `[NAR] Size Change`: the amount changed compared to the main branch. **Tips on reading this data:** - For NixOS configurations you generally care only about the `Size` (closure size/size on disk). - Reduce the `Size` by disabling unneeded services/default packages. - For Packages you care about both the `Size` and the `NAR Size`. - Reduce the `NAR Size` by reducing the size of the build outputs, e.g. don't copy unnecessary data to the $out dir, optimize binaries for size, etc. - Reduce the `Size` by reducing the dependencies (e.g. `buildInputs`). - Don't worry too much about size, some dependencies are deduplicated, e.g. `glibc` adds ~40MiB to the `Size`, but is generally shared by ~every binary on the system, so, chances are, you are already including it from somewhere else and statically linking with e.g. `musl` is not gonna improve things. # Packages | Name | Size | Size Change | NAR Size | NAR Size Change | |------|-----:|------------:|---------:|----------------:| | `default` | 35MiB | 192B | 2.8MiB | 192B | | `git-cliff` | 60MiB | 0B | 19MiB | 0B | | `webnsupdate` | 35MiB | 192B | 2.8MiB | 192B |

jalil merged commit 70ed898f1d into main 2025-01-31 21:35:59 +01:00

jalil deleted branch push-258298cb008a5819f12721a1101c162b 2025-01-31 21:35:59 +01:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

jalil

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: jalil/webnsupdate#91

No description provided.