jalil/webnsupdate
1
0
Fork 0
Code Issues 2 Pull requests 3 Releases Activity Actions

wip: add Ipv6Prefix::with_client_id impl #102

Draft
jalil wants to merge 1 commit from push-skqkrqmuywls into main
pull from: push-skqkrqmuywls
merge into: jalil:main
Conversation 1 Commits 1 Files changed 1 +23
jalil commented 2025-02-05 23:22:59 +01:00
Owner
Copy link

Leaving here so I don't forget about the code

Leaving here so I don't forget about the code
jalil self-assigned this 2025-02-05 23:22:59 +01:00
jalil added 1 commit 2025-02-05 23:22:59 +01:00
wip: add Ipv6Prefix::with_client_id impl
Some checks failed
/ build (push) Successful in 27s
Details
/ check (clippy) (push) Failing after 11s
Details
/ check (module-ipv4-only-test) (push) Successful in 30s
Details
/ check (module-ipv4-test) (push) Successful in 29s
Details
/ check (module-ipv6-only-test) (push) Successful in 29s
Details
/ check (module-ipv6-test) (push) Successful in 29s
Details
/ check (module-nginx-test) (push) Successful in 30s
Details
/ check (nextest) (push) Successful in 3s
Details
/ check (treefmt) (push) Successful in 3s
Details
/ report-size (push) Successful in 7s
Details
87c3e31160
forgejo-actions commented 2025-02-05 23:26:42 +01:00
First-time contributor
Copy link

Flake output sizes

Definitions:

  • Name: the name of the package/configuration.
  • Size: the closure size (size on disk/NAR size + all transitive dependencies).
  • NAR Size: the size of the build output (package without the dependencies).
  • [NAR] Size Change: the amount changed compared to the main branch.

Tips on reading this data:

  • For NixOS configurations you generally care only about the Size (closure size/size on disk).
    • Reduce the Size by disabling unneeded services/default packages.
  • For Packages you care about both the Size and the NAR Size.
    • Reduce the NAR Size by reducing the size of the build outputs, e.g. don't copy unnecessary data to the $out dir, optimize binaries for size, etc.
    • Reduce the Size by reducing the dependencies (e.g. buildInputs).
    • Don't worry too much about size, some dependencies are deduplicated, e.g. glibc adds ~40MiB to the Size, but is generally shared by ~every binary on the system, so, chances are, you are already including it from somewhere else and statically linking with e.g. musl is not gonna improve things.

Packages

Name Size Size Change NAR Size NAR Size Change
default 35MiB 0B 2.8MiB 0B
git-cliff 60MiB 0B 19MiB 0B
webnsupdate 35MiB 0B 2.8MiB 0B
# Flake output sizes **Definitions:** - `Name`: the name of the package/configuration. - `Size`: the closure size (size on disk/NAR size + all transitive dependencies). - `NAR Size`: the size of the build output (package without the dependencies). - `[NAR] Size Change`: the amount changed compared to the main branch. **Tips on reading this data:** - For NixOS configurations you generally care only about the `Size` (closure size/size on disk). - Reduce the `Size` by disabling unneeded services/default packages. - For Packages you care about both the `Size` and the `NAR Size`. - Reduce the `NAR Size` by reducing the size of the build outputs, e.g. don't copy unnecessary data to the $out dir, optimize binaries for size, etc. - Reduce the `Size` by reducing the dependencies (e.g. `buildInputs`). - Don't worry too much about size, some dependencies are deduplicated, e.g. `glibc` adds ~40MiB to the `Size`, but is generally shared by ~every binary on the system, so, chances are, you are already including it from somewhere else and statically linking with e.g. `musl` is not gonna improve things. # Packages | Name | Size | Size Change | NAR Size | NAR Size Change | |------|-----:|------------:|---------:|----------------:| | `default` | 35MiB | 0B | 2.8MiB | 0B | | `git-cliff` | 60MiB | 0B | 19MiB | 0B | | `webnsupdate` | 35MiB | 0B | 2.8MiB | 0B |
Some checks failed
/ build (push) Successful in 27s
Required
Details
/ check (clippy) (push) Failing after 11s
Required
Details
/ check (module-ipv4-only-test) (push) Successful in 30s
Required
Details
/ check (module-ipv4-test) (push) Successful in 29s
Required
Details
/ check (module-ipv6-only-test) (push) Successful in 29s
Required
Details
/ check (module-ipv6-test) (push) Successful in 29s
Required
Details
/ check (module-nginx-test) (push) Successful in 30s
Required
Details
/ check (nextest) (push) Successful in 3s
Required
Details
/ check (treefmt) (push) Successful in 3s
Required
Details
/ report-size (push) Successful in 7s
Required
Details
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin push-skqkrqmuywls:push-skqkrqmuywls
git checkout push-skqkrqmuywls
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
jalil
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: jalil/webnsupdate#102
No description provided.
Delete branch "push-skqkrqmuywls"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?