jalil/webnsupdate
1
0
Fork 0
Code Issues 2 Pull requests 3 Releases Activity Actions

fix(webnsupdate): updating IPv6 in ipv4-only mode
All checks were successful
/ build (push) Successful in 1s
Details
/ check (clippy) (push) Successful in 2s
Details
/ check (module-ipv4-only-test) (push) Successful in 7s
Details
/ check (module-ipv4-test) (push) Successful in 7s
Details
/ check (module-ipv6-only-test) (push) Successful in 7s
Details
/ check (module-ipv6-test) (push) Successful in 7s
Details
/ check (module-nginx-test) (push) Successful in 6s
Details
/ check (nextest) (push) Successful in 2s
Details
/ check (treefmt) (push) Successful in 2s
Details
/ report-size (push) Successful in 1s
Details

Browse source 
Dumb logic error T-T.
This commit is contained in:
Jalil David Salamé Messina 2025-01-31 21:45:47 +01:00
parent 70ed898f1d
commit 13c9c544a7
Signed by: jalil
GPG key ID: F016B9E770737A0B
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/main.rs
View file

@ -517,20 +517,20 @@ async fn update_records(
if let Some(ip) = ipv4 {
let ip = IpAddr::V4(ip);
if !state.ip_type.valid_for_type(ip) {
if state.ip_type.valid_for_type(ip) {
_ = trigger_update(ip, &state).await?;
} else {
tracing::warn!("requested update of IPv4 but we are {}", state.ip_type);
}
_ = trigger_update(ip, &state).await?;
}
if let Some(ip) = ipv6 {
let ip = IpAddr::V6(ip);
if !state.ip_type.valid_for_type(ip) {
if state.ip_type.valid_for_type(ip) {
_ = trigger_update(ip, &state).await?;
} else {
tracing::warn!("requested update of IPv6 but we are {}", state.ip_type);
}
_ = trigger_update(ip, &state).await?;
}
Ok("Successfully updated IP of records!\n")
@ -566,13 +566,13 @@ async fn trigger_update(
error!("nsupdate failed with code {status}");
Err((
StatusCode::INTERNAL_SERVER_ERROR,
"nsupdate failed, check server logs",
"nsupdate failed, check server logs\n",
)
.into())
}
Err(error) => Err((
StatusCode::INTERNAL_SERVER_ERROR,
format!("failed to update records: {error}"),
format!("failed to update records: {error}\n"),
)
.into()),
}